[No QA] fix: include env variables in Rock's fingerprint by adhorodyski · Pull Request #73632 · Expensify/App

adhorodyski · 2025-10-28T13:07:54Z

Explanation of Change

This PR includes all custom env variables defined using .env in Rock's fingerprinting mechanism.

Fixed Issues

$
PROPOSAL: https://expensify.slack.com/archives/C08CZDJFJ77/p1760640153256349

Tests

Use rock fingerprint (CLI) to make sure each combination of these environment variables is producing a unique hash.
Make sure this issue is resolved now.
Trigger iOS and Android remote builds' workflows to ensure they pass fine.

I tested this against different matrix combinations of custom variables and can confirm it is producing unique hashes for each of them. It's up to a developer to comment out custom values when working locally to hit remote builds' cache (CI runs with 0 custom values).

Offline tests

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-10-28T13:08:31Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable · 2025-10-28T14:48:12Z

        android: platformAndroid({sourceDir: isHybrid ? './Mobile-Expensify/Android' : './android'}),
    },
+    fingerprint: {
+        env: ['USE_NGROK', 'NGROK_URL', 'SECURE_NGROK_URL'],


Can we just include the whole .env file? There are lots of variables in there and I don't think we want to maintain a list of variables that can effect this.

I'd say we shouldn't. Most of these variables do not take part in the build process (are JS only) and this is pretty much what a @latest tag is. Instead, we should list out which of these are actually baked in and thus problematic (ngrok vars are) - this makes it far easier to maintain (they likely won't change) and debug.

I thought that all variables in .env ended up in native?

Also, just for reference, all these variables occasionally will change and I don't think anyone will check them or know that rock is caching them

Yup .env I think ends up baked in thanks to react-native-config, but there's no .env on the CI and Rock does not auto-inject entire env.process into the hashing mechanism to keep it predictable. Do you think we should read .env in the config file and spread all its values into this array?

Yes, I think that solution will be more reliable, even if we have a few more local builds. I think that's a fine trade off.

Busy with Sentry investigations today, I'll update the PR on tomorrow 👍🏻

Updated the PR, curious how it'll work tbh. It behaves ok on my end, but I don't deal with lots of them specified locally. We just have to be aware that in order to hit the remove cache, developer would have to completely comment out custom variables specified in .env.

…uilds

chuckdries

I'm onboard with this change. Yes it will result in fewer build cache hits, but as long as they're still compiled into the native code, their values affect its behavior. I prefer correctness over speed here for sure!

Just tested it and it works great, though I will say I'm not sure why you'd ever have a GITHUB_TOKEN in your App .env

chuckdries · 2025-11-12T20:55:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-11-12T22:09:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-13T17:29:32Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.2.58-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-14T18:25:14Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.58-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: include ngrok env variables in the fingerprint for remote builds

cbdab10

adhorodyski requested a review from a team as a code owner October 28, 2025 13:07

melvin-bot Bot assigned adhorodyski Oct 28, 2025

melvin-bot Bot requested review from mollfpr and removed request for a team October 28, 2025 13:08

AndrewGable reviewed Oct 28, 2025

View reviewed changes

fix: include all custom env variables in the fingerprint for remote b…

918a673

…uilds

chuckdries previously approved these changes Nov 6, 2025

View reviewed changes

chore: list individual keys for rock env

a96b4fc

adhorodyski dismissed chuckdries’s stale review via a96b4fc November 12, 2025 20:48

chuckdries approved these changes Nov 12, 2025

View reviewed changes

Merge branch 'Expensify:main' into fix/rock-ngrok-config

d02beb0

chuckdries merged commit 50a59c9 into Expensify:main Nov 12, 2025
15 checks passed

OSBotify mentioned this pull request Nov 13, 2025

Deploy Checklist: New Expensify 2025-11-13 #75063

Closed

52 tasks

Conversation

adhorodyski commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 28, 2025

Uh oh!

AndrewGable Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

adhorodyski Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

AndrewGable Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

AndrewGable Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

adhorodyski Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

AndrewGable Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adhorodyski Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

adhorodyski Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuckdries left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuckdries commented Nov 12, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Nov 12, 2025

Uh oh!

OSBotify commented Nov 13, 2025

Uh oh!

OSBotify commented Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adhorodyski commented Oct 28, 2025 •

edited

Loading

AndrewGable Nov 3, 2025 •

edited

Loading

adhorodyski Nov 6, 2025 •

edited

Loading

chuckdries left a comment •

edited

Loading